Skip to content

👷 [RUM-16634] Require WebView wildcard to match at least one character#4785

Merged
kikoveiga merged 1 commit into
mainfrom
kikoveiga/webview-wildcard-min-one-char
Jun 16, 2026
Merged

👷 [RUM-16634] Require WebView wildcard to match at least one character#4785
kikoveiga merged 1 commit into
mainfrom
kikoveiga/webview-wildcard-min-one-char

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Motivation

matchesHostEntry used >=, which let a * match zero characters (e.g. preview-*.shopist.io matched preview-.shopist.io). A wildcard should match at least one character.

Changes

  • matchesHostEntry: >=>.
  • A bare * still matches every non-empty host.
  • Added test cases for the zero-char rejection and bare *.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jun 15, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 76.80% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 745b302 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jun 15, 2026

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.04 KiB 172.04 KiB -1 B -0.00%
Rum Profiler 8.01 KiB 8.01 KiB 0 B 0.00%
Rum Recorder 21.09 KiB 21.09 KiB 0 B 0.00%
Logs 54.64 KiB 54.64 KiB -1 B -0.00%
Rum Slim 129.72 KiB 129.72 KiB -1 B -0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@kikoveiga kikoveiga force-pushed the kikoveiga/webview-wildcard-min-one-char branch from c89f6b8 to 745b302 Compare June 15, 2026 20:13
@kikoveiga kikoveiga marked this pull request as ready for review June 15, 2026 20:22
@kikoveiga kikoveiga requested a review from a team as a code owner June 15, 2026 20:22
@kikoveiga

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kikoveiga kikoveiga merged commit 102c2c1 into main Jun 16, 2026
31 of 32 checks passed
@kikoveiga kikoveiga deleted the kikoveiga/webview-wildcard-min-one-char branch June 16, 2026 13:25
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants